search

jpetazzo / pipework

Software-Defined Networking tools for LXC (LinuX Containers)
Apache License 2.0
4.22k stars 727 forks source link

dhcpcd improvements #91

Closed h0tbird closed 9 years ago

h0tbird commented 10 years ago

  1. Redirect stderr to stdout when running which to avoid noise every time pipework tries to discover the appropriate DHCP client.

    which: no udhcpc in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/home/marc/bin:/usr/local/go/bin)
  2. dhcpcd first execution will prevent subsequent executions to succeed by locking the pid file associated to CONTAINER_IFNAME
  3. Disable dhcpcd run hooks. Hooks are executed by the host.
  4. Gain 5 seconds by not claiming the DHCP assigned IP address.
jpetazzo commented 10 years ago

Agreed on everything, except the dhcpcd part which IMHO requires more discussion.

If you want to amend the PR to include all fixes except that one, I'll be happy to merge (and we'll probably end up merging the dhcpcd stuff as well; but I'd like to talk about it first :-))

Thank you for your contribution!

h0tbird commented 9 years ago

Closing since almost everything is related to 'dhcpcd'.