search

jpetrucciani / hubspot3

python3.6+ hubspot client based on hapipy, but modified to use the newer endpoints and non-legacy python
MIT License
147 stars 73 forks source link

Yet another Ecommerce Bridge Sync Error endpoint #53

Closed W1ldPo1nter closed 5 years ago

W1ldPo1nter commented 5 years ago

This PR mainly introduces a method to use yet another endpoint to query sync errors of the Ecommerce Bridge API. I found that the other two endpoints that generally serve a similar purpose cannot be used in conjunction with OAuth (even though the docs did mention it at the time), which I reported to HubSpot. A few weeks later, the docs suddenly list a third endpoint that can only be used with OAuth tokens.

So now there 3 endpoints and they all only work with different kinds of authentication. :man_shrugging: This is why I also added checks for the used auth type to the client whenever one of these methods is called. Hopefully this will help others to avoid the pain I went through to figure this out.

jpetrucciani commented 5 years ago

Thanks for the explanation and fixes! That's quite annoying from HubSpot.

I'll review/merge and hopefully get a release out soon!

jpetrucciani commented 5 years ago

This is now live on pip as version 3.2.24!

Thanks again for your contributions! 😄