jpetrucciani / hubspot3

python3.6+ hubspot client based on hapipy, but modified to use the newer endpoints and non-legacy python
MIT License
147 stars 73 forks source link

Missing API endpoints (bridge, deals, line items) #56

Closed hkage closed 5 years ago

hkage commented 5 years ago

Hi there,

this PR adds some missing endpoints for different API clients:

A small note: due to the fact that all deal tests currently use your development Hubspot account I added a test for the deal deletion that actually creates and deletes a deal (to not differ from the other test implementations). That can cause CI errors if the maximum request limit was reached. It would be the best to refactor those test and to mock out the Hubspot calls, but I guess you already discussed that topic with some of my colleagues.

jpetrucciani commented 5 years ago

Awesome - I'll review and merge in soon!

hkage commented 5 years ago

Thank you!

jpetrucciani commented 5 years ago

This is now live on pip as version 3.2.27

Thanks for your contributions! 😄

hkage commented 5 years ago

Great :+1: Thanks for the quick review and release.