search

jpetrucciani / hubspot3

python3.6+ hubspot client based on hapipy, but modified to use the newer endpoints and non-legacy python
MIT License
147 stars 73 forks source link

Add parameter to enable paging when getting sync errors #61

Closed BuddhaOhneHals closed 4 years ago

BuddhaOhneHals commented 4 years ago

We need to be able to define a starting point when fetching the sync errors. To start always with page 1 is too restrictive as we want to skip the first X errors.

I called the parameter starting_page and not something like offset because page is the wording used by HubSpot (even if it's not really a page as in pagination, instead it's an offset).

jpetrucciani commented 4 years ago

Good call! I like it 😄

I'll review and merge soon!

jpetrucciani commented 4 years ago

This is now live on pip as version 3.2.30!

Thanks for your contribution! 😄