search

jpetrucciani / hubspot3

python3.6+ hubspot client based on hapipy, but modified to use the newer endpoints and non-legacy python
MIT License
147 stars 73 forks source link

Add line_items get_all #67

Closed jisson closed 4 years ago

jisson commented 4 years ago

Add a get_all method to the LinesClient as it was missing.

jpetrucciani commented 4 years ago

Looks good to me - Thanks again for the continued contributions! I'm fixing a small issue with testing on python 3.5, but then this should all be good to release today!

jisson commented 4 years ago

Sorry about the issues with Python 3.5. I may open a new PR in a few hours (it should be the last one for today :)).

I would be very careful regarding those issues for the next one :+1:

jpetrucciani commented 4 years ago

No worries! My fault for not having the CI tests set up on PRs yet 😜 It just appears to be with the fact that dicts are ordered by default in 3.6+, but in 3.5 the order is not stable, so the query params in the generated URLs don't match on tests sometimes - I made a little helper in hubspot3/utils.py that can help with that in the meantime!

I just published 3.2.34 to pip (that should be live now!) but I can definitely get another release out today if you have more PRs!

Thanks again for all the contributions! 😄