Remove overriding default bool evaluation of exceptions

jpetrucciani / hubspot3

python3.6+ hubspot client based on hapipy, but modified to use the newer endpoints and non-legacy python

MIT License

146 stars 72 forks source link

Remove overriding default bool evaluation of exceptions #93

Closed zzZIMAWAKE closed 4 years ago

zzZIMAWAKE commented 4 years ago

Raising this pull request as I'm not sure if there is a reason behind Hubspot exceptions being evaluated as False, more of a question but if there's no reason it'd be great to have the exceptions follow the inbuilt exception evaluation.

jpetrucciani commented 4 years ago

Yep, that's definitely weird - I can't remember exactly why this was this way. Looks like it was included in my first commit to this repo as well! 😆

It should be fine to remove these!

jpetrucciani commented 4 years ago

This is now live on pip as version 3.2.46.

Thanks for your contribution! 😄