search

jpetrucciani / mypy-check

github action for python's mypy type checker tool
MIT License
33 stars 14 forks source link

`pyproject.toml` support #23

Open Olegt0rr opened 2 years ago

Olegt0rr commented 2 years ago

Please, add pyproject.toml support

mscheltienne commented 2 years ago

+1 for this!

mscheltienne commented 2 years ago

Is it actually not supported?

      - name: Run mypy
        uses: jpetrucciani/mypy-check@master
        with:
          path: './mne_icalabel'
          mypy_flags: '--config-file pyproject.toml'

That seems to work fine.

anton-buyskikh commented 1 year ago

Perhaps the best experience would be if the action followed the defaults of mypy istself, which is described on the top of https://mypy.readthedocs.io/en/stable/config_file.html :

Mypy supports reading configuration settings from a file. By default it uses the file mypy.ini with a fallback to .mypy.ini, then pyproject.toml, then setup.cfg in the current directory, then $XDG_CONFIG_HOME/mypy/config, then ~/.config/mypy/config, and finally .mypy.ini in the user home directory if none of them are found; the --config-file command-line flag can be used to read a different file instead (see Config file).

gaby commented 1 year ago

@jpetrucciani Any updates on this? I tried using the yaml from @mscheltienne but it doesnt install dependencies