search

jpetso / formstamper

Formstamper: work-in-progress GUI application (using Electron) for batch filling PDF forms
GNU General Public License v3.0
1 stars 1 forks source link

Fix Promise.all() call for PDF generation results. #24

Closed jpetso closed 5 years ago

jpetso commented 5 years ago

I thought I had previously fixed this in commit ed07b75, but Promise.all() doesn't work with callback syntax. Given that there are no tests for PDF generation results and the UI hasn't hooked it up either, my error went unnoticed.

It's still untested, but this change mirrors the learnings from another, tested, change. It's more likely to work now.

choilmto commented 5 years ago

Good catch! I searched the file and now the pattern between all uses of Promise.all now follow this pattern.