jpfairbanks / SemanticModels.jl

A julia package for representing and manipulating model semantics
MIT License
77 stars 17 forks source link

Scaling model missing some expressions #101

Closed jpfairbanks closed 5 years ago

jpfairbanks commented 5 years ago

@infvie @kuncao0228 I was working with the SEIR model example notices something missing:

function micro_1(du, u, parms, time)
    # PARAMETER DEFS
    # β transmition rate
    # r net population growth rate
    # μ hosts' natural mortality rate
    # Κ population size
    # α disease induced mortality rate

    β, r, μ, K, α = parms
    dS = r*(1-S/K)*S - β*S*I
    dI = β*S*I-(μ+α)*I
    du = [dS,dI]
end

Is there something I am missing here?

infvie commented 5 years ago

I'll check against the cookbook and fix it

infvie commented 5 years ago

It looks like this is the same. http://epirecip.es/epicookbook/chapters/deleo1996/julia

jpfairbanks commented 5 years ago

It was inside a macro definition in the cookbook, but now is using the macro-free api. fixed in #100

Quar commented 4 years ago

Sorry for the trouble, but just in case it worths noting for beginners -- it seems the Jupyter Notebook at SemanticModels.jl/examples/epicookbook/notebooks/SimpleDeterministicModels/ScalingModel.ipynb

is not updated with ScalingModel.jl (still missing S, I = u).

Thanks enormously for the abundance of great examples and demos by the way!