search

jpfleury / clearlooks-phenix

GTK3 port of the Clearlooks theme
GNU General Public License v3.0
96 stars 42 forks source link

GTK 3.20 #28

Closed de-vri-es closed 7 years ago

de-vri-es commented 8 years ago

GTK 3.20 again broke backwards compatibility for themes. This time they're promising stable naming so I suppose that this might be the last time they break themes. Who knows.

I'm not really up to speed, and I couldn't find a comprehensive list of what changed. This link promises documented node names, but I can't find them: https://blogs.gnome.org/mclasen/2015/11/20/a-gtk-update/

Unless it's the list of defines at the bottom here: https://developer.gnome.org/gtk3/stable/GtkStyleContext.html I'm not familiar with GTK theming or GTK at all, so I don't know if that is the relevant information.

P.S. Everyone contributing to this theme: thank you. It's the one things that makes GTK 3 bearable.

calestyo commented 8 years ago

I collected a number of issues I've noted at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=821409 some of them may actually be GTK issues, since it doesn't work with Adwaita either.

bencaradocdavies commented 8 years ago

firefox 45.0.2-1 is horribly broken on debian/unstable with clearlooks-phenix. Symptoms are most space around menu buttons and menu items is missing, dialog buttons lack their outlines, and all mouseover highlighting is missing.

andrewshadura commented 8 years ago

https://www.bountysource.com/issues/32831473-gtk-3-20 :)

hishamhm commented 8 years ago

Just to confirm the bug, I'm having the exact same issues on Firefox as @bencaradocdavies.

hishamhm commented 8 years ago

Just found another Clearlooks port that works on 3.20: Mate's TraditionalOk:

https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/TraditionalOk

calestyo commented 8 years ago

TraditionalOk, doesn't work (at least in Debian sid) either.

de-vri-es commented 8 years ago

Maybe Debian is shipping an old version? You could try from source.

de-vri-es commented 8 years ago

The version shipped with Arch is working great as far as I can tell. Thanks for the tip @hishamhm .

dilworks commented 8 years ago

Unfortunately TraditionalOK doesn't really blend under GTK3. It looks... so off. So nope, not an acceptable workaround for me :/

And I'm in a dire situation right now, since MATE 1.14 landed with its massive switchover to GTK3 in Debian Testing, and I can't stand those constant theme breakages because someone at GNOME keeps having UX ephiphanes every 3 months.

So... is there any hope for a fix?

bencaradocdavies commented 7 years ago

Looks fixed in Debian unstable clearlooks-phenix-theme 6.0.3+git20161006-2; see #32.

jpfleury commented 7 years ago

Fixed in Clearlooks-Phénix v7.

dilworks commented 7 years ago

Well, it's working...

...except that things like menubars now look freakin' tall! Almost as tall as toolbars, but not quite. There is now a ~4px margin on top of bottom of menus that should not be there. This also causes the MATE panel to display oversized systray icons if a panel contains a menubar widget.

andrewshadura commented 7 years ago

Could you please post a screenshot?

Thanks.

Cheers, Andrew

On 12 Oct 2016 02:29, "Tom Maneiro" notifications@github.com wrote:

Well, it's working...

...except that things like menubars now look freakin' tall! Almost as tall as toolbars, but not quite. There is now a ~4px margin on top of bottom of menus that should not be there. This also causes the MATE panel to display oversized systray icons if a panel contains a menubar widget.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jpfleury/clearlooks-phenix/issues/28#issuecomment-253085798, or mute the thread https://github.com/notifications/unsubscribe-auth/AAS4BcXKAcxhx6joykeSGN2STFxxRjKLks5qzCnKgaJpZM4IEk6j .

dilworks commented 7 years ago

OK, here is a example with MATE desktop running Pluma: http://i.imgur.com/ogwcEJH.png

Look at the menubars (I've thrown a GTK2 app -Seamonkey- as comparison). On this screenshot you can see the extra margin when a menu is open: http://i.imgur.com/nhoFF11.png (The menu itself renders fine)

Bonus bug: on that Pluma screenshot take a look at the status bar. Notice that borders render outside the statusbar area, reaching the document workspace (those two items in the middle are actually buttons that open dropdown menus too, might be the same thing?)