jpfleury / clearlooks-phenix

GTK3 port of the Clearlooks theme
GNU General Public License v3.0
96 stars 42 forks source link

Window-frame margin issue with gtk 3 dialogs #3

Closed stevenhoneyman closed 7 years ago

stevenhoneyman commented 9 years ago

Environment: openbox, compton, GTK 3.12, clearlooks-phenix 5.0.6 Problem (first dialog here):

2014-09-28_t132549_746x209_scrot

Workaround: To get the result shown in the middle dialog above, here's what my settings looked like:

.window-frame {
    border-width: 0px;
    border-radius: 7px 7px 0 0;
    border-style: solid;
    margin: 0px;
}

To get the 3rd dialog (rounded corners don't match anything else on my themes):

.window-frame {
    border-width: 0px;
    border-radius: 0;
    border-style: solid;
    margin: 0px;
}
jpfleury commented 9 years ago

@andrewshadura: this code comes from your commit 77426482. Can we change the border width and the margin without causing regression elsewhere?

andrewshadura commented 9 years ago

Probably. I don't remember why I took 10px margin here, maybe we need to check the Adwaita code to see how they do it.

jpfleury commented 9 years ago

Adwaita:

.window-frame {
border-radius: 7px 7px 0 0;
border-width: 0px;
box-shadow: 0 3px 9px 1px rgba(0, 0, 0, 0.5), 0 0 0 1px rgba(0, 0, 0, 0.23);
/* this is used for the resize cursor area */
margin: 10px; }

Raleigh:

.window-frame {
border-color: darker (@bg_color);
border-radius: 7px 7px 0 0;
border-width: 1px;
border-style: solid;
box-shadow: 0 2px 8px 3px alpha(black, 0.5);
margin: 10px;
}
stevenhoneyman commented 9 years ago

I've just tested the Adwaita snippet, and the cursor resize area comment is true... but I would never notice unless I set it to something silly like 30px

jpfleury commented 9 years ago

Fixed in v5.0.7. Thanks.

stevenhoneyman commented 9 years ago

This is re-broken in v6 (Arch linux changed to GTK 3.14 today), do you want me to open a new bug ticket?

jpfleury commented 9 years ago

I was not sure it was still an issue with v6, so I've not fixed it for this version. I'll do it soon. No need to open a new issue.

stevenhoneyman commented 9 years ago

No problem - thanks :+1:

Balletie commented 9 years ago

This might be the same issue I'm having:

screenshot_2015-08-23_19-29-57

Environment: Openbox 3.6.1-1, GTK 3.16.6-1, clearlooks 6.0.3-1, no compositor, Debian stretch/sid

paride commented 8 years ago

Same problem here, I get the same black border as @Balletie. My environment is: Debian sid, i3 window manager, clearlook-phenix 6.0.3, no compositor, gtk 3.18.

jpfleury commented 8 years ago

@Balletie @legovini Clearlooks-Phénix is not yet compatible with GTK 3.16 and 3.18. A specific version will be needed to address problems with these new GTK versions.

jpfleury commented 7 years ago

There's a new release (Clearlooks-Phénix v7) that supports GTK 3.20. I don't plan to support older versions, so I close this report, but anyone can make a pull request.