search

jpfleury / clearlooks-phenix

GTK3 port of the Clearlooks theme
GNU General Public License v3.0
96 stars 42 forks source link

Theme breaks chromium's menu #33

Open paride opened 7 years ago

paride commented 7 years ago

When using this theme the menu of the chromium browser is broken as can be seen in the attached screenshot. What happens is that the item hovered by the mouse pointer becomes invisible (white text, white background, white borders). This does not happen with other themes. Chromium is set to use its native "Classic" theme, not the GTK theme, but still it is clearlooks-phenix that triggers the issue.

This happens on a up-to-date Debian "sid" system, with:

clearlooks-phenix-theme 7.0.1 libgtk-3 3.22.1 chromium 53.0.2785.143

The theme is great, I hope this can be fixed. Thank you!

Paride

broken-menu

sibskull commented 7 years ago

Look at my https://github.com/jpfleury/clearlooks-phenix/pull/34 It fixes hovered menu item.

paride commented 7 years ago

I can confirm your PR fixes it, thank you!

sibskull commented 7 years ago

There is fix in chromium upstream: https://chromium.googlesource.com/chromium/src.git/+/7e59887c97f2e2cc6727b349de76a9a4e08536ab

paride commented 7 years ago

Thanks again @sibskull. As it is going to be fixed upstream it's probably better not to merge your patch, leave this issue open for reference, and close the issue once a fixed chromium is released (v56?).

sibskull commented 7 years ago

My one-line patch does not break anything, so it's useful to apply it before (and leave after) release of next chromium version.