jpfleury / clearlooks-phenix

GTK3 port of the Clearlooks theme
GNU General Public License v3.0
96 stars 42 forks source link

scrollbar slider 1px right-border isnt clickable #41

Open teleshoes opened 7 years ago

teleshoes commented 7 years ago

if i fullscreen a window (say, firefox) and move my mouse all the way to the right of the screen, and try to click on the vertical scroll slider, the scroll warps down instead of grabbing the scrollbar slider. (if i move the mouse slightly away from the right side of the screen, the slider highlights and becomes clickable and i can grab it and drag it to scroll as usual)

this is because the slider scrollbar-slider trough has an unclickable border, with 1px on the right, so the scrollbar gets clicked instead of the slider

also, my window manager doesnt have window borders in fullscreen mode. not sure if other people do, so perhaps most people already suffer having to be more precise than all-the-way-to-the-right. i was suffering because i move the mouse all the way to the right to grab the scrollbar all the time, and moving it one pixel to the left is much more difficult.

i say this is a bug in clearlooks-phenix because this works in other gtk3 themes (Adwaita), as well as Clearlooks and Clearlooks-Phenix on gtk2. (maybe its a bug in gtk3 that the borders arent clickable on the scrollbar-slider's trough)

workaround in ~/.config/gtk-3.0:

/* fixes bug in Clearlooks-Phenix,
 * where clicking rightmost 1px edge of slider
 * does a warp-scrolls instead of grabbing slider
 */
.scrollbar.vertical trough,
scrollbar.vertical trough {
  border-width: 1px 0px 2px 1px;
}
ralphldcm commented 6 years ago

Teleshoes: I also have this problem and find it very annoying. I tried your solution, but I couldn't make it work. I created the file ~/.config/gtk-3.0/gtk.css and put your above code into it. I also tried adding this code into the existing file /user/share/themes/Clearlooks-Phenix/gtk-3.0/gtk.css, both at the beginning at at the end of the file. None of this worked. The behavior on a full screen window, pointer all the way to the right was still warp scrolling. If you could tell me if I have done something wrong or, if necessary, update your fix, I would appreciate it.

teleshoes commented 6 years ago

sorry mate, it should work. make sure your changes are being picked up though. maybe try adding a negative right margin?

ralphldcm commented 6 years ago

Just a few more comments. First, I have the problem only on Firefox, my most used app. Second, I fiddled a lot with the scrollbar section of /usr/share/themes/Clearlooks-Phenix/gtk-3.0/gtk-widgets.css. I made the scrollbar wider/narrower, the trough wider/narrower, the borders wider/narrower, the slider wider/narrower. Nothing fixed the problem. It seems that on both the right and left edges of the SLIDER only, there is a border that when clicked, sends the slider racing to the bottom. It is not too difficult to find this border. With the pointer inside the slider, the color is light blue. Moving the pointer toward either side until it just barely goes dark blue and click sends the slider racing. I think the slider border will have to be redefined, and I don't know how to do that.