search

jpfleury / clearlooks-phenix

GTK3 port of the Clearlooks theme
GNU General Public License v3.0
96 stars 42 forks source link

Button bottom border is displaced (GTK 3.22) #50

Open trancexpress opened 6 years ago

trancexpress commented 6 years ago

Especially visible when a button is on focus (e.g. with pressing tab), due to the outline:

GTK 3.22: gtk_322_button_outline_and_border GTK 3.14: gtk_314_button_outline_and_border

I have reported https://gitlab.gnome.org/GNOME/gtk/issues/206 for the behaviour change, but I think the problem is in the theme itself.

Namely, border.svg defines a 16x16 pixels image. Then it defines a 15x14 pixels rectangle with path width 1 pixel. So the bottom line of the image is an empty line. GTK 3.22 apparently takes this empty line to heart and moves the bottom border up.

Either setting an image size of 16x15 or a border of 15x15 fixes the problem.

I'll be changing the svgs for the iloveeclipse fork (https://github.com/iloveeclipse/clearlooks-phenix/tree/eclipse-patches). However I'm not sure whether the svg should stay at 16x16 size and the border should be 15x15, or if the size should be 16x15 with 15x14 border.

trancexpress commented 6 years ago

Proposed patch:

borders_patch.txt

Will use this for some time in https://github.com/iloveeclipse/clearlooks-phenix/tree/eclipse-patches, will let you know how it goes.