jpfleury / clearlooks-phenix

GTK3 port of the Clearlooks theme
GNU General Public License v3.0
96 stars 42 forks source link

GtkScale slider is painted outside of container (GTK 3.22) #51

Open trancexpress opened 6 years ago

trancexpress commented 6 years ago

Here is an inspection of a GtkContainer with a GtkScale:

gtk322_scale_slider_image

This is more pronounced in Eclipse SWT, where anything outside of the container is not painted:

gtk322_scale_in_swt

The following seems to fix the problem:

diff --git a/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css b/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css
index 09c9159..89d9e58 100644
--- a/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css
+++ b/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css
@@ -384,14 +384,10 @@ row:selected:focus progressbar trough {
  * GtkScale *
  ************/

-scale.vertical {
-    min-width: 10px;
-    padding: 3px 5px;
-}
-
-scale.horizontal {
-    min-height: 10px;
-    padding: 5px 2px;
+scale {
+  min-height: 13px;
+  min-width: 21px;
+  padding: 12px;
 }

 scale.horizontal slider,
trancexpress commented 6 years ago

I'll try out some other changes to the theme and will post my findings.

trancexpress commented 6 years ago

Here is what I arrived at:

diff --git a/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css b/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css
index 09c9159..030bd14 100644
--- a/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css
+++ b/src/clearlooks-phenix-theme-7.0.1/gtk-3.0/gtk-widgets.css
@@ -386,12 +386,12 @@ row:selected:focus progressbar trough {

 scale.vertical {
     min-width: 10px;
-    padding: 3px 5px;
+    padding: 9px 5px;
 }

 scale.horizontal {
     min-height: 10px;
-    padding: 5px 2px;
+    padding: 5px 9px;
 }

 scale.horizontal slider,

Before:

padding_as_is

After:

padding_9x