search

jpfleury / gedit-markdown

Support for Markdown language in gedit
GNU General Public License v3.0
130 stars 29 forks source link

Porting the markdown-preview to current versions of gedit #9

Open nielsmde opened 9 years ago

nielsmde commented 9 years ago

Proposed changes concern

Detailed changes are in the commit messages.

jpfleury commented 9 years ago

Thanks a lot for this pull request. I'll try to look at it soon.

jpfleury commented 9 years ago

@nielsmde I wonder, which gedit version did you use to test your pull request?

nielsmde commented 9 years ago

I'm currently using gedit 3.14

nielsmde commented 9 years ago

I upgraded to Gnome 3.18 recently and the plugin seems to work in gedit 3.18 too.

Except for some warnings:

/home/niels/.local/share/gedit/plugins/markdown-preview/__init__.py:21: PyGIWarning: Gdk was imported without specifying a version first. Use gi.require_version('Gdk', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gdk, Gtk, Gedit, GObject, WebKit, Gio
/home/niels/.local/share/gedit/plugins/markdown-preview/__init__.py:21: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gdk, Gtk, Gedit, GObject, WebKit, Gio
/home/niels/.local/share/gedit/plugins/markdown-preview/__init__.py:21: PyGIWarning: Gedit was imported without specifying a version first. Use gi.require_version('Gedit', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gdk, Gtk, Gedit, GObject, WebKit, Gio
/home/niels/.local/share/gedit/plugins/markdown-preview/__init__.py:21: PyGIWarning: WebKit was imported without specifying a version first. Use gi.require_version('WebKit', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gdk, Gtk, Gedit, GObject, WebKit, Gio
sys:1: PyGIWarning: Peas was imported without specifying a version first. Use gi.require_version('Peas', '1.0') before import to ensure that the right version gets loaded.
jpfleury commented 8 years ago

Sorry for the delay. I'll try to look at it as soon as possible. Thanks a lot.

kitzberger commented 8 years ago

Work's for me on Gedit 3.18.3 (Ubuntu 16.04 LTS), thanks a lot ;-)

marc1uk commented 7 years ago

Appears to work nicely for me on 3.14.0, after installing gir1.2-webkit-3.0 and python3-markdown. Thanks nielsmde. 👍 But... it doesn't seem to work very well? I've attached two images: one from gedit-markdown, and a screenshot from the same file implemented on https://github.com/WCSim/WCSim. The formatting hasn't rendered properly... mdfail mdnofail

danielesegato commented 6 years ago

Any news on this?

I'm on Ubuntu 16.04.4 LTS, gedit 3.18.3 and am affected by this issue: https://github.com/jpfleury/gedit-markdown/issues/15

darkdragon-001 commented 4 years ago

I just want to let you know, that I created a fork (based on @nielsmde's work): https://github.com/darkdragon-001/gedit-markdown/

Please test the latest release. Pull requests are always welcome!