search

jpfudger / chordproc

Collect and process lyrics, chords and tabs
1 stars 0 forks source link

Improve chord identification. #23

Open jpfudger opened 6 years ago

jpfudger commented 6 years ago

Currently any word is considered to be a chord if it begins with a note name, with some miserable hard-coded exceptions.

A better method would be to extract the root note (and/or trailing bass note) and then check if the remaining chord decorator is valid.

A list of valid decorators (e.g. m, dim, maj7, ...) could readily be built by scanning our existing html for <div class=chord>.

jpfudger commented 5 years ago

Once we have a list of decorators, we could document them. Imagine that!

jpfudger commented 5 years ago

"Willie the Weeper" has the lyrics: "Ba-da Ba-da Ba-da-da", which are currently being detected as chords. A new detection technique should resolve this.