Logger is not able to match stackLine

jpg0 / ohj

Openhab Javascript Library

Eclipse Public License 2.0

6 stars 2 forks source link

Logger is not able to match stackLine #10

Open simonihmig opened 3 years ago

simonihmig commented 3 years ago

stackLine was at <program> (test.js:3) in my case., which did not match the regex in https://github.com/jpg0/ohj/blob/master/log.js#L60, and was throwing therefore (see #9)

On first look:

the regex seems to expect a :lineNumber:columnNumber ending, which was not the case for me
it seems to use named capture groups, which are a proposed ECMAScript extension, not sure if GraalVM really supports these already?

jpg0 commented 3 years ago

The challenge here has been the GraalJS has not stuck with the same format across versions, and also I think I have seen slightly different formatting at points with the same version (possibly based on whether and how it locates the source file).

It should support named capture groups though, pretty sure it has worked!

I regard this parsing part as needed a rewrite though.