search

jpgattuso / seacarb-git

Seawater carbonate chemistry with R
8 stars 11 forks source link

Fix typos in SeaFET functions #51

Closed umihoshijima closed 6 years ago

umihoshijima commented 6 years ago

The first lines in the seaFET functions refer to variables which do not exist in the functions. I corrected these so that these lines would work as intended.

I first came across the issue when I tried to calibrate SeaFET data using a single E0_25. The error I got was a strange one ("Object P not found"), which led me to look into these functions.

jpgattuso commented 6 years ago

Thank you very much for noticing this silly mistake and for proposing a fix.

jpgattuso commented 6 years ago

Note that your fix was incomplete. Watch out for 3.2.4 on CRAN. Thanks anyway for spotting the mistake!

umihoshijima commented 6 years ago

Thank you for providing and maintaining this resource for the community! I am finishing up my Ph.D. with Gretchen Hofmann here in California, and use seacarb extensively for my work.

jpgattuso commented 6 years ago

Thanks! It is always great to know that the package is useful.

Regards, jp

--  Jean-Pierre Gattuso | http://www.obs-vlfr.fr/~gattuso | @jpGattuso

On 15 January 2018 at 22:45:07, Umihiko Hoshijima (notifications@github.com) wrote:

Thank you for providing and maintaining this resource for the community! I am finishing up my Ph.D. with Gretchen Hofmann here in California, and use seacarb extensively for my work.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.