search

jpgohlke / twitch-chat-filter

58 stars 37 forks source link

Incompatible with BTTV #105

Closed kanegasi closed 10 years ago

kanegasi commented 10 years ago

There is a browser addon called "BetterTTV" created and maintained by NightDev, the creators of NightBot. This script is incompatible with the addon and causes the filter to not work (nothing in chat gets filtered). There's also some funkyness with the setting buttons on the bottom.

BetterTTV: http://www.nightdev.com/betterttv/

hugomg commented 10 years ago

Related to #78

Apparently, we would need to change to overriding the methods directly on the room instance instead of on Room.prototype

kanegasi commented 10 years ago

I apologize for not searching. I was not aware this is/was a constant issue. I only saw 6 open issues.

hugomg commented 10 years ago

No need to apologize. The only reason we closed that other issue is because we though it wasnt affecting too many people.

jpgohlke commented 10 years ago

I'm going to close this Issue as a duplicate and reopen #78, as that Issue has a more extensive discussion and goes into the technical aspects of implementing this feature.

jpgohlke commented 10 years ago

Nevermind, apparently reopening the Issue automatically thinks I just wanted to merge in the Pull Request and close it again. Reopening.

kanegasi commented 10 years ago

This is more of a suggestion, but before I discovered BTTV, I was using an emote script (https://github.com/cletusc/Userscript--Twitch-Chat-Emotes). While discovering BTTV, I noticed they have that exact script included in BTTV. Would it be feasible to work with BTTV to merge this filter script as a more Twitch-wide general filter while still maintaining TPP-specific options? Maybe move the TPP filters into the custom area and treat them as custom filters that come with BTTV.

jpgohlke commented 10 years ago

Interesting idea. I do actually use our filter on other streams in order to filter out some annoying stuff, haha. The custom blacklist feature is really quite useful. I don't think it would be smart to become dependent on another (possibly volatile) plugin, though.

hugomg commented 10 years ago

Now that I looked at the BTTV source code with greater attention, I think its even more incompatible with our script than I thought. BTTV completely bypasses the existing Twitch chat system and re-implements everything from scratch.

The worse points are that BTTV uses its own message queuing system (our filters are written to work with Twitch's existing message queue) and it has its own logic for handling the chat input textarea (this breaks our slowmode helper).

I'm getting the impression that its not feasible for any other Twitch userscripts to be compatible with BTTV. :(

jpgohlke commented 10 years ago

I'm going to close this as "won't fix" for now. If more interest is generated for this in the future or if it becomes more viable, technically, I'll reopen.

Freso commented 9 years ago

I would like to see this happen.

Tyrrr commented 9 years ago

I'd also love to have both scripts at the same time. What's weird is that the all lowercase function works but the filters don't.

hugomg commented 9 years ago

The lowercase functions working is just a coincidence. All we are doing is adding some css to the chat window that makes all the text inside it display as lowercase. If you inspect the raw HTML via the developer tools you will see that the real text still contains upper case letters and its just being displayed differently. This is also why turning the lowercase filter on and off works.

Its been a while since I checked this but IIRC the big problem is that TCF works by mucking with the internals of the official twitch chat system and bttv reimplements those internals in an incompatible manner.