search

jpgohlke / twitch-chat-filter

58 stars 37 forks source link

Fix messages not appearing as filtered #174

Closed soulweaver91 closed 8 years ago

soulweaver91 commented 8 years ago

Recently, the filter stopped working for me. It was an easy fix once I looked into it, though. Basically, the HTML structure of the messages in the chat was altered so that the generated CSS didn't match the messages anymore. The new structure (after running the message through the filters) that the commit also takes into account is as follows:

<div class="ember-view TppFilterCommand TppFilterSmall" id="ember6894">
  <li class="ember-view message-line chat-line" id="ember6895">
    <div class="indicator"></div>
    <span class="timestamp float-left">7:11</span>
    <span class="badges float-left"></span>
    <span class="from" style="color:#B22222">Danneborger</span>
    <span class="colon">:</span>
    <span class="message" style="">down</span>
  </li>
</div>

They might be running some kind of limited testing on only a subset of users based on the lack of comments on the breakage, apart from this one which might or might not be related. To account for that, I also left the old CSS rule in place.

soulweaver91 commented 8 years ago

175 might also be related.

MattiasBuelens commented 8 years ago

Thanks for the quick fix! I just tested it locally and it works great! :+1:

Just one small request: could you update your PR to not include the updated chat_filter.min.js? I prefer doing the version bump and minification in a separate commit, whenever a new version gets rolled out.

soulweaver91 commented 8 years ago

Sure :p