jpgpi250 / piholemanual

files referred to in my pihole installation manual
115 stars 14 forks source link

https://raw.githubusercontent.com/oneoffdallas/dohservers/master/list.txt - Out of sync #11

Closed Bingo600 closed 2 years ago

Bingo600 commented 2 years ago

First off - THANK YOU for your great effort, excellent pdf documents , and the "Best" DoH blocklist "known to mankind" :-)

On https://github.com/oneoffdallas/dohservers

I noticed the below list.txt is 4 month old https://raw.githubusercontent.com/oneoffdallas/dohservers/master/list.txt

Whereas the iplist.txt is 3 month old. https://raw.githubusercontent.com/oneoffdallas/dohservers/master/iplist.txt

Some ip addresses has been committed https://github.com/oneoffdallas/dohservers/commit/59f4d33fd16d64f31214235c6614dd6d011a9c20

As i use pfSense (great pdf guide) i'm using your list , and "dallas" iplist.txt , and noticed that a lot of 45.90.30.xx entries was missing from your list. Actually seems like he added a full 45.90.30.x/24 as single ip entries.

Maybe you could just switch to the iplist instead.

Thanx from Denmark /Bingo

jpgpi250 commented 2 years ago

How the script works:

you noticed some (not all) missing 45.x.x.x. This problem has been looked at and explained here

I want to keep the list reliable (no false positives), thus only adding IP addresses that are the result of a succesful dig, however, as explained in issue 7, the list may be incorrect in different regions. The only solution is to generate the list locally (on one of your machines)

Some dig results:

It may (or may not - false positives) be a good idea to use the IP lists from oneoffdallas, however I can NOT verify these are DoH servers and will NOT be adding these addresses to the list.

Browsing the web will provide other lists (example). The problem for my script remains the same: I cannot confirm/deny these are actually DoH servers. That is why I don't use these lists.

Hope this helps...

Bingo600 commented 2 years ago

I get the reason , and totally agree. Better to leave one off , that get false positives. I'll close this one

Thank you