jphillipsCrestron / ch5-react-ts-template

Minimal demonstration of turning a Vite project with React + TypeScript acting as a single page application into a Crestron HTML5 project, along with PWA support
10 stars 3 forks source link

Fixed bug where Touch Panel (TS770) was able to send joins to processor, but not receive feedback #2

Closed jmaertzProfessionalAudioDesign closed 8 months ago

jphillipsCrestron commented 9 months ago

@jmaertzProfessionalAudioDesign I just pushed an update to the repo (#3) when you get a chance feel free to test if this works on your TS-770. This update switched from using the CJS builds of the Crestron libraries to the UMD builds, so we should no longer even need to bind the CrComLib bridge methods to the window object anymore. In my tests against a TS-1070, TSW-1060, and WebXPanel this is working now.

jmaertzProfessionalAudioDesign commented 9 months ago

Sorry I couldn't get back to you sooner. I was out of the office by the time this came through.

I just tested it out. This update works perfectly!

On Fri, Feb 16, 2024 at 6:39 PM Justin Phillips @.***> wrote:

@jmaertzProfessionalAudioDesign https://github.com/jmaertzProfessionalAudioDesign Can you test the TS-770 using the new branch I just attached to the repo? You can clone it by running: git clone --branch UsingUMD https://github.com/jphillipsCrestron/ch5-react-ts-template.git

I just tested with a TS-770, TSW-1060, and a 4-series WebXPanel with bidirectional join communication working - just want to confirm if this works for you as well if you build with this branch. I've been wanting to switch to using UMD instead of CJS modules so that we don't have to bother with manually binding the CrComLib bridge methods to the window and that's what this branch does.

— Reply to this email directly, view it on GitHub https://github.com/jphillipsCrestron/ch5-react-ts-template/pull/2#issuecomment-1949536808, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7H3IEXLCTXZNTEPIIYLELTYT735FAVCNFSM6AAAAABDMT74SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGUZTMOBQHA . You are receiving this because you were mentioned.Message ID: @.***>

jphillipsCrestron commented 8 months ago

Glad ot hear it, I will closeout this PR then.