search

jpilfold / ngx-image-viewer

An image viewer component for Angular 2+
MIT License
49 stars 54 forks source link

Keyboard navigation #12

Closed saberrahul closed 6 years ago

saberrahul commented 6 years ago

Expected Behavior : Keyboard navigation should work only for focused image gallery. Current Behavior : Currently when there are more then one image galleries on page, keyboard navigation changes the images for all image galleries.

jpilfold commented 6 years ago

Good point, I'll take a look at this now

jpilfold commented 6 years ago

Okay, I've merged in a fix for this issue, and published a new version to NPM. Let me know if you're happy with the change

saberrahul commented 6 years ago

With version 1.0.8, build is failing with below error message

ERROR in node_modules\ngx-image-viewer\ngx-image-viewer.d.ts.ImageViewerComponent.html(7,38): : Property 'loading' is private and only accessible within class 'ImageViewerComponent'.

Seems like you have to change the property 'loading' to public.

jpilfold commented 6 years ago

Sorry, don't know how I missed that... I've just made the fix. New version is 1.0.9

jpilfold commented 6 years ago

@saberrahul Have you had a chance to take a look yet? Just want to get these issues closed off if I can.

saberrahul commented 6 years ago

Yes, this issue is fixed and shall be closed. Great work.