search

jpilfold / ngx-image-viewer

An image viewer component for Angular 2+
MIT License
49 stars 54 forks source link

Reset Method Should Be Public #20

Closed AnthonyNWRI closed 6 years ago

AnthonyNWRI commented 6 years ago

Hi I'm using your ngx-image-viewer component. It works great except for one small issue. The reset method is private. I am managing a carousel of images and displaying the selected image with the ngx-image-viewer. If the user zooms in or out and then clicks on another image in the carousel, the new image is rendered, but at the zoom level set for the previous image. This is not what I need. If i use the component provided next/previous buttons to navigate the list of images, the component calls reset prior to rendering each new image. This is the behavior i need when i specify the new image index to display. I could get this behavior in my code if the reset() method were made public. Anthony

jpilfold commented 6 years ago

This makes sense. I'll create the change, and publish it this evening

AnthonyNWRI commented 6 years ago

Thanks so much!! Anthony

From: jpilfold [notifications@github.com] Sent: Friday, September 14, 2018 12:35 AM To: jpilfold/ngx-image-viewer Cc: Anthony Arrigo; Author Subject: Re: [jpilfold/ngx-image-viewer] Reset Method Should Be Public (#20)

This makes sense. I'll create the change, and publish it this evening

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jpilfold/ngx-image-viewer/issues/20#issuecomment-421246301, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ApQASy3X--cVr4yDcm4PdhTq-13p_zghks5ua040gaJpZM4WoUQF.

jpilfold commented 6 years ago

Okay, I've just published a new version (1.0.11) to npm with this change in there, hope it helps. Let me know if there are any issues.