search

jpilfold / ngx-image-viewer

An image viewer component for Angular 2+
MIT License
49 stars 54 forks source link

Issues in screenfull #29

Open reberinformatik opened 5 years ago

reberinformatik commented 5 years ago

Screenfull has fixed some issues in the latest version. Would it be possible to update the package?

Related: #23

troglodito commented 5 years ago

We also still get this error mentioned in #23.

Updating screenfull.js version to at least v4.0.1, where the problem has been fixed, will automatically solve the problem several users were reporting in the issue mentioned above.

Manually editing the sreenfull.js - as e.g. described in this comment is not a real solution when you have integrated ngx-image-viewer in your project and call npm installfor a build.

Could you please update the package and publish a new release?

ebitauld commented 5 years ago

I implemented this library in angular 7. Updating screenfull.js version to at least v4.0.1 does not solve the issue for me. I tried npm install screenfull@4.0.1, but I still get the same error : "Uncaught (in promise) TypeError: Document not active"

troglodito commented 5 years ago

@ebitauld : I understand that you did an own implementation of this library or a fork, right? Then calling npm install on screenfull won't do the trick, instead you have to open package.json in your project, update the dependency to screenful.js (in ngx-image-viewer 1.0.13 it's currently "^3.3.2", which was actually resolved in package-lock.json to version 3.3.2 and then call npm install on your project - this is what we kindly ask @jpilfold to do.

udham-singh commented 4 years ago

Anyone having this issue can refer to this fork which resolves it. Thanks.