search

jpilfold / ngx-image-viewer

An image viewer component for Angular 2+
MIT License
49 stars 55 forks source link

Update Screenful Package #35

Open deepakgonda opened 5 years ago

deepakgonda commented 5 years ago

Old dependency gives error : screenfull.js:102 Uncaught (in promise) TypeError: Document not active at exit (screenfull.js:102)

deepakgonda commented 5 years ago

Please merge this and update the package in npm.

troglodito commented 5 years ago

Yes, @jpilfold , merging this pull request and updating npm would solve both issues #23 and #29 . Thank you.

deepakgonda commented 5 years ago

@jpilfold , Can you please accept this pull request, so that issues #23 and #29 can be closed, we need this solved and updated in NPM package, If you don't have time for updating this to npm, please give me write access, I will merge this and update on NPM also.

nirav5884 commented 5 years ago

Is the owner looking at this PR or not?

prasanna-5796 commented 4 years ago

@jpilfold, can you merge the above changes