Lower-case PublicSuffix lookup

jpillora / go-tld

TLD Parser in Go

MIT License

127 stars 19 forks source link

Lower-case PublicSuffix lookup #10

Closed jmdacruz closed 4 years ago

jmdacruz commented 4 years ago

It looks like PublicSuffix is case sensitive when looking up TLDs, so google.com is ICANN-managed but google.Com is not, which is not correct (both are equivalent). This PR addresses this issue by lower-casing the domain before calling PublicSuffix

jpillora commented 4 years ago

LGTM

jmdacruz commented 4 years ago

Please add a release/tag when you get a chance. Thanks @jpillora!

jpillora commented 4 years ago

Done :)

On 17 Nov 2020 at 12:45:14 pm, Marcelo Da Cruz Pinto < notifications@github.com> wrote:

Please add a release/tag when you get a chance. Thanks @jpillora https://github.com/jpillora!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jpillora/go-tld/pull/10#issuecomment-728631826, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2X44G7PJHRIA4U2Y5FXDSQHISVANCNFSM4TXSPXKA .