Fix exception on trying to access mime.lookup

jpillora / grunt-aws

A Grunt interface into the Amazon Node.JS SDK

171 stars 44 forks source link

Fix exception on trying to access mime.lookup #69

Closed rchl closed 5 years ago

rchl commented 5 years ago

Revert back to v1 of mime dependency as v2 has breaking changes and code wasn't updated.

rchl commented 5 years ago

Fixes #68

jpillora commented 5 years ago

Thanks for the PR, before we merge, can you test with the new API: https://github.com/jpillora/grunt-aws/issues/68#issuecomment-466516006 ?

rchl commented 5 years ago

I've looked into that before making PR but I've decided not to migrate code to new API as it seemed not trivial and I wanted fix to be as safe as possible.

The part that was not trivial was use of mime.charsets.lookup()* in current code which doesn't even seem to be available in v2.

I just didn't want to refactor that and risk regressions.

https://www.npmjs.com/package/mime/v/1.6.0

rchl commented 5 years ago

Thank you for quick merging. :)