search

jpillora / installer

One-liner for installing binaries from Github releases
https://i.jpillora.com/installer
MIT License
206 stars 52 forks source link

Adding .tgz extension to github file search #12

Closed drmikecrowe closed 3 years ago

jpillora commented 3 years ago

Can you remove the change to use .local/bin ?

I don't think everyone will have that directory?

m1 ~/.local ls -lah
Permissions Size User     Date Modified Name
drwx------     - jpillora  8 Dec  2020  share
jpillora commented 3 years ago

Instead of updating the go template, we could update the script to:

  1. check .local/bin exists
  2. check .local/bin is in the PATH
  3. not sudo move
  4. not root user

then use .local/bin

drmikecrowe commented 3 years ago

Yeah, that's what I was trying to accomplish but I was new to Go

drmikecrowe commented 3 years ago

Reverted.

Here's what I was trying to implement:

jpillora commented 3 years ago

Thanks! Will checkout the PR soon