jpillora / installer

One-liner for installing binaries from Github releases
https://i.jpillora.com/installer
MIT License
206 stars 52 forks source link

Installer gets confused by aarch64-linux #17

Closed ajeetdsouza closed 1 year ago

ajeetdsouza commented 3 years ago

Hey @jpillora, I was trying to use installer with zoxide, but it seems to be downloading the aarch64 binary instead of amd64 on Linux.

Here's the case statement generated by curl 'https://i.jpillora.com/ajeetdsouza/zoxide!':

case "${OS}_${ARCH}" in
"linux_amd64")
    URL="https://github.com/ajeetdsouza/zoxide/releases/download/v0.7.0/zoxide-aarch64-unknown-linux-musl.tar.gz"
    FTYPE=".tar.gz"
    ;;
"linux_arm")
    URL="https://github.com/ajeetdsouza/zoxide/releases/download/v0.7.0/zoxide-armv7-unknown-linux-musleabihf.tar.gz"
    FTYPE=".tar.gz"
    ;;
"darwin_amd64")
    URL="https://github.com/ajeetdsouza/zoxide/releases/download/v0.7.0/zoxide-x86_64-apple-darwin.tar.gz"
    FTYPE=".tar.gz"
    ;;
*) fail "No asset for platform ${OS}-${ARCH}";;
esac
jpillora commented 3 years ago

Yep needs better arm support!

On Wed, 19 May 2021 at 2:14 am ajeetdsouza @.***> wrote:

Hey @jpillora https://github.com/jpillora, I was trying to use installer with zoxide https://github.com/ajeetdsouza/zoxide, but it seems to be downloading the aarch64 binary instead of amd64 on Linux.

Here's the case statement generated by curl ' https://i.jpillora.com/ajeetdsouza/zoxide!':

case "${OS}_${ARCH}" in"linux_amd64") URL="https://github.com/ajeetdsouza/zoxide/releases/download/v0.7.0/zoxide-aarch64-unknown-linux-musl.tar.gz" FTYPE=".tar.gz" ;;"linux_arm") URL="https://github.com/ajeetdsouza/zoxide/releases/download/v0.7.0/zoxide-armv7-unknown-linux-musleabihf.tar.gz" FTYPE=".tar.gz" ;;"darwin_amd64") URL="https://github.com/ajeetdsouza/zoxide/releases/download/v0.7.0/zoxide-x86_64-apple-darwin.tar.gz" FTYPE=".tar.gz" ;;*) fail "No asset for platform ${OS}-${ARCH}";;esac

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jpillora/installer/issues/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2X43VDCTYMX6E6FZOM6TTOKG45ANCNFSM45C26TUA .

jpambrun commented 1 year ago

Same problem with delta, fd, lsd. I imagine the aarch64 tag is common among rust projects.

k9s gives me ppc.

Better arch heuristics is probably needed..