search

jpillora / installer

One-liner for installing binaries from Github releases
https://i.jpillora.com/installer
MIT License
206 stars 52 forks source link

Some versions are not parsing properly #32

Closed electrocucaracha closed 1 year ago

electrocucaracha commented 1 year ago

There are some versions which are removed the hyphen char

$ curl -s 'https://i.jpillora.com/GoogleContainerTools/kpt@v1.0.0-beta.24!!'
echo 'release tag v1.0.0beta.24 not found'
$ curl -s https://api.github.com/repos/GoogleContainerTools/kpt/releases | grep '"tag_name": "v1.0.0-beta.24",'
    "tag_name": "v1.0.0-beta.24",

So apparently this conditional fails, maybe splitHalf method is modifying the value

Update

It works without sudo move option.

curl -s 'https://i.jpillora.com/GoogleContainerTools/kpt@v1.0.0-beta.24!' | bash
jpillora commented 1 year ago

Thanks will check it out

Try dropping one off the !

?

On Thu, 26 Jan 2023 at 6:49 am Victor Morales @.***> wrote:

There are some versions which are removed the hyphen char

curl -s @.***!!' echo 'release tag v1.0.0beta.24 not found'

— Reply to this email directly, view it on GitHub https://github.com/jpillora/installer/issues/32, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2X43MBTD4BBM4J7CSTF3WUF7T7ANCNFSM6AAAAAAUGXAFOY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

electrocucaracha commented 1 year ago

I wasn't aware that functionality was dropped in v0.3.3. I'll close this, but it's weird why the release tag removes the hyphen character, I'm not sure if that can causes future issues.

jpillora commented 1 year ago 
curl -s 'https://i.jpillora.com/GoogleContainerTools/kpt@v1.0.0-beta.24!!'

works now it seems