jpillora / installer

One-liner for installing binaries from Github releases
https://i.jpillora.com/installer
MIT License
206 stars 52 forks source link

Feature/windows #44

Closed abdheshnayak closed 6 months ago

abdheshnayak commented 6 months ago
jpillora commented 6 months ago

Thanks for the PR :) is there a particular reason we need to use BinSource? the shell script uses Program

abdheshnayak commented 6 months ago

The repository can be monolithic where multiple binaries can be distributed so, that's why I introduced source where users can provide the name of binary. And It will filter and download the exact binary.

For example: github.com/kloudlite/kl

Where the repository is going to distribute two binaries kl and kli.

abdheshnayak commented 6 months ago

Please review and if there is something wrong, you can mention i will update it so you can accept the pull request. In case of pr is not that useful or something else please do close the pr by providing your feedback.

jpillora commented 6 months ago

I would like to add windows support to installer, but I would also like it be high-quality, and work the same way as the bash script installer.

currently:

(1) change would be:

I would consider multi-binary downloads as an extra feature - though it should work the same way as it does in bash

(2) change would be to add a method to the Assets

(3) change is optional, and it would be to support multiple archive types. id accept the PR if it only supported zip, but would be nice if we could do gz and tar.gz too (see https://github.com/kloudlite/bin-installer/blob/f055686c741e934ed6abc39de33645f4ffa3e933/handler/handler_execute.go#L154)

lastly, i am very short for time at the moment! so I may not respond quickly

abdheshnayak commented 6 months ago

Pull Request #46 embodies similar functionalities to this, yet it demonstrates an enhanced level of code quality. In light of this, and to maintain the integrity and optimization of the project's codebase, I propose the closure of this pull request. This decision is made with the consideration of ensuring that we adopt the most efficient and well-structured solutions.