search

jpillora / installer

One-liner for installing binaries from Github releases
https://i.jpillora.com/installer
MIT License
206 stars 52 forks source link

Installer generates incorrect script for Linux and Darwin #8

Closed mcsakoff closed 4 years ago

mcsakoff commented 4 years ago

Running, e.g.:

curl -fsSL https://i.jpillora.com/jesseduffield/lazygit@v0.16.2 | bash

fails with Error: No asset for platform linux-amd64 on Linux and Error: No asset for platform darwin-amd64 on Mac.

The reason is lines ~45-47

     case `uname -s` in
     Darwin) OS="darwin";;
     Linux) OS="linux";;

and ~63-96:

    case "${OS}_${ARCH}" in
    "Linux_386") ...
    "Linux_amd64") ...
    "Linux_arm") ...
    "Darwin_386") ...
    "Darwin_amd64") ...

.

The cases must be lowercased as well.

jpillora commented 4 years ago

See https://i.jpillora.com/jesseduffield/lazygit@v0.16.2?type=script