jpillora / installer

One-liner for installing binaries from Github releases
https://i.jpillora.com/installer
MIT License
206 stars 52 forks source link

Move into path does not work on https://i.jpillora.com/ #9

Closed corneliusludmann closed 3 years ago

corneliusludmann commented 3 years ago

When I run https://i.jpillora.com/chisel!, move-to-path is false despite the ! at the end of the URL. See:

image

When I run the latest version from master on my own it seems to work. Could it be that there is an issue with your installation?

jpillora commented 3 years ago

Strange works for me What browser are you using?

On Wed, 7 Oct 2020 at 7:15 pm Cornelius A. Ludmann notifications@github.com wrote:

When I run https://i.jpillora.com/chisel!, move-to-path is false despite the ! at the end of the URL. See:

[image: image] https://user-images.githubusercontent.com/24960040/95304985-b0834e80-0885-11eb-8038-a85793edb35c.png

When I run the latest version from master on my own it seems to work. Could it be that there is an issue with your installation?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jpillora/installer/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2X43MSQNCA63M6MHZCHDSJQPT7ANCNFSM4SHB2LRQ .

corneliusludmann commented 3 years ago

It's Google Chrome Version 85.0.4183.121 (Official Build) (64-bit) on Arch Linux.

It also happens with curl. See: https://community.gitpod.io/t/chisel-only-works-successfully-once-i-have-no-idea-why/1924

jpillora commented 3 years ago

Ahhhhh, confirmed the bug. Installer caches the resulting script, caching the move settings. Will fix 👍

jpillora commented 3 years ago

Fixed in https://github.com/jpillora/installer/commit/55f50710c542a5a778a134c971d6742713faaa37