search

jpillora / ipfilter

A package for IP Filtering in Go (golang)
MIT License
387 stars 47 forks source link

v1.1.0 breaks semver compatibility #12

Closed andreyluchin closed 4 years ago

andreyluchin commented 4 years ago

I have some code that depends on ipfilter module and noticed that 1.1.0 breaks compatibility when it definitely must not.

ipfilter.NewNoDB seems to exist in 1.0.0 but not in 1.1.0. There might be other breaking changes I haven't noticed yet.

Please, either restore compatibility in 1.1 or bump the version to 2.0

jpillora commented 4 years ago

Ah very true, will restore compatibility though I’ll make all of those APIs no-ops. Acquiring a MaxmindDB is too onerous.

On Mon, 24 Feb 2020 at 10:00 pm Andrey Luchin notifications@github.com wrote:

I have some code that depends on ipfilter module and noticed that 1.1.0 breaks compatibility when it definitely must not https://github.com/golang/go/wiki/Modules#modules.

ipfilter.NewNoDB seems to exist in 1.0.0 but not in 1.1.0. There might be other breaking changes I haven't noticed yet.

Please, either restore compatibility in 1.1 or bump the version to 2.0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jpillora/ipfilter/issues/12?email_source=notifications&email_token=AAE2X47ID5VAZQR3AZKYKPDREOSDXA5CNFSM4K2F4NG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPWFNDQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2X46ILUQRK54ILU45QK3REOSDXANCNFSM4K2F4NGQ .

jpillora commented 4 years ago

Published v1.2.1