jpillora / node-edit-google-spreadsheet

A simple API for editing Google Spreadsheets
304 stars 101 forks source link

Added extra meta data to the spreadsheet object on initialisation #14

Closed simonmudd closed 10 years ago

jpillora commented 10 years ago

Hi Simon, thanks for the PR, will take a look soon

simonmudd commented 10 years ago

Thanks Jamie, you are a star!

Si.

On Wed, Feb 5, 2014 at 11:36 AM, Jaime Pillora notifications@github.comwrote:

Merged #14https://github.com/jpillora/node-edit-google-spreadsheet/pull/14 .

Reply to this email directly or view it on GitHubhttps://github.com/jpillora/node-edit-google-spreadsheet/pull/14 .

jpillora commented 10 years ago

No worries, see https://github.com/jpillora/node-edit-google-spreadsheet#spreadsheetraw for the data that you need, I didnt include work/spreadsheetCount because you can just do raw.spreadsheet.length instead :)

simonmudd commented 10 years ago

Hey Jamie,

I have just got round to using the new stuff and I have found that when using a worksheetId the spreadsheet.raw does not get populated. This means I have to use a worksheetName and it's considerably slower.

Thanks.

Si.

On Wed, Feb 5, 2014 at 12:48 PM, Jaime Pillora notifications@github.comwrote:

No worries, see https://github.com/jpillora/node-edit-google-spreadsheet#spreadsheetrawfor the data that you need, I didnt include work/spreadsheetCount because you can just do raw.spreadsheet.length instead :)

Reply to this email directly or view it on GitHubhttps://github.com/jpillora/node-edit-google-spreadsheet/pull/14#issuecomment-34162565 .

jpillora commented 10 years ago

Hi Simon, Just confirming, when you use spreadsheetName, then spreadsheet.raw.spreadsheets is populated and when you use worksheetName, then spreadsheet.raw.worksheets is populated. So this isn't working?

simonmudd commented 10 years ago

When I use spreadsheetId then the spreadsheet.raw is not populated, same as when I use the worksheetId the spreadsheet.raw is not populated

Sorry for the lack of clarity.

Si.

On Sun, Feb 9, 2014 at 6:30 AM, Jaime Pillora notifications@github.comwrote:

Hi Simon, Just confirming, when you use spreadsheetName, then spreadsheet.raw. spreadsheets is populated and when you use worksheetName, then spreadsheet.raw.worksheets is populated. So this isn't working?

Reply to this email directly or view it on GitHubhttps://github.com/jpillora/node-edit-google-spreadsheet/pull/14#issuecomment-34566863 .

jpillora commented 10 years ago

spreadsheet.raw is just a container, spreadsheet.raw.worksheets and spreadsheet.raw.speadsheets are what get populated...

simonmudd commented 10 years ago

Yeah I get that but my problem is that I am not getting anything at all in the spreadsheet.raw. By this I mean there is no spreadsheet.raw.spreadsheetsor spreadsheet.raw.worksheets

On Mon, Feb 10, 2014 at 9:02 AM, Jaime Pillora notifications@github.comwrote:

spreadsheet.raw is just a container, spreadsheet.raw.worksheets and spreadsheet.raw.speadsheets are what get populated...

Reply to this email directly or view it on GitHubhttps://github.com/jpillora/node-edit-google-spreadsheet/pull/14#issuecomment-34610961 .

jpillora commented 10 years ago

Ahhh, okay then that's a bug, I'm going on vacation for a couple weeks tomorrow, so I'm afraid I won't be able to look into this until I get back

On Mon, Feb 10, 2014 at 8:49 PM, simonmudd notifications@github.com wrote:

Yeah I get that but my problem is that I am not getting anything at all in the spreadsheet.raw. By this I mean there is no spreadsheet.raw.spreadsheetsor spreadsheet.raw.worksheets

On Mon, Feb 10, 2014 at 9:02 AM, Jaime Pillora <notifications@github.com

wrote:

spreadsheet.raw is just a container, spreadsheet.raw.worksheets and spreadsheet.raw.speadsheets are what get populated...

Reply to this email directly or view it on GitHub< https://github.com/jpillora/node-edit-google-spreadsheet/pull/14#issuecomment-34610961

.

Reply to this email directly or view it on GitHubhttps://github.com/jpillora/node-edit-google-spreadsheet/pull/14#issuecomment-34614267 .