jpillora / node-edit-google-spreadsheet

A simple API for editing Google Spreadsheets
304 stars 101 forks source link

Add: Create spreadsheet from access token, bypassing auth client. #18

Closed PelayoBesa closed 10 years ago

PelayoBesa commented 10 years ago

I'm using google's 'googleapis' module to generate an access token so I don't need the client portion of the auth module. Since I didn't find a way to do this using your module I'm submitting this pull request.

It includes:

jpillora commented 10 years ago

thanks for the PR :) will merge soon

On Thursday, January 23, 2014, PelayoBesa notifications@github.com wrote:

I'm using google's 'googleapis' module to generate an access token so I don't need the client portion of the auth module. Since I didn't find a way to do this using your module I'm submitting this pull request.

It includes:

You can merge this Pull Request by running

git pull https://github.com/PelayoBesa/node-edit-google-spreadsheet create-spreadsheet-with-token

Or view, comment on, or merge it at:

https://github.com/jpillora/node-edit-google-spreadsheet/pull/18 Commit Summary

  • Add: Create spreadsheet from access token, bypassing auth client.

File Changes

  • M README.mdhttps://github.com/jpillora/node-edit-google-spreadsheet/pull/18/files#diff-0(17)
  • M lib/auth.jshttps://github.com/jpillora/node-edit-google-spreadsheet/pull/18/files#diff-1(9)
  • M lib/index.jshttps://github.com/jpillora/node-edit-google-spreadsheet/pull/18/files#diff-2(2)

Patch Links:

- https://github.com/jpillora/node-edit-google-spreadsheet/pull/18.patch

— Reply to this email directly or view it on GitHubhttps://github.com/jpillora/node-edit-google-spreadsheet/pull/18 .

BaseInfinity commented 10 years ago

Awesome pull! I'm using this PR in production and it works well!

jpillora commented 10 years ago

hey sorry for the delay, taking a look now...

jpillora commented 10 years ago

looks good, merging a few PRs, will republish soon :)