search

jpillora / node-edit-google-spreadsheet

A simple API for editing Google Spreadsheets
304 stars 101 forks source link

Fix #38 #39

Closed ssimono closed 10 years ago

ssimono commented 10 years ago

Considers result from request an object and get error information from it.

0xgeert commented 10 years ago

This fails if result.feed.entry is an array (since batch:status doesn't exist on result.feed.entry but on result.feed.entry[x])

0xgeert commented 10 years ago

For ref: https://developers.google.com/gdata/docs/batch#Handling_Errors

You need to check the batch:status element of each entry in the response to find out whether the associated operation was successfully processed.

Moreover, probably useful to add a failsave in case no send was called without adding entries.

Can probably add some work in here the couple of days to make this more robust.

jpillora commented 10 years ago

Hey @ssimono thanks for the fix. Can you comment on @gebrits remarks? Also one minor nitpick, can we keep the indentation uniform with 2 spaces?

0xgeert commented 10 years ago

@jpillora I think this is good to go.

jpillora commented 10 years ago

Thanks @ssimono and @gebrits, will merge this soon