search

jpillora / node-edit-google-spreadsheet

A simple API for editing Google Spreadsheets
304 stars 101 forks source link

Native module compilation errors #47

Open jpillora opened 10 years ago

jpillora commented 10 years ago

Bug: Had reports via email recounting native module compilation errors due to node-expat, which is used by the current XML parser. If this is a big issue, we can apply @ubik2's patch https://gist.github.com/ubik2/95d18f849b7b2878e4e0.

mderazon commented 9 years ago

Compilation warnings looks scary indeed but are probably not a big deal.

Couple of thoughts regarding xml parsing:

  1. Doesn't Google Sheet provide json api as well ?
  2. Maybe switch to https://github.com/Leonidas-from-XIV/node-xml2js which looks more maintained anyway. Looks like it has more or less same features set as the current xml parser, but I don't know how difficult it will be to switch.
jpillora commented 9 years ago
  1. JSON results though errors are still XML which means we'll need an XML parser anyway
  2. I think we chose the native one because it had higher performance though maybe the module you referenced is fast enough?

On Thursday, February 26, 2015, Michael Derazon notifications@github.com wrote:

compilation warnings looks scary indeed but are probably not a big deal https://github.com/node-xmpp/node-expat/issues/58.

Couple of thoughts regarding xml parsing

  1. Doesn't Google Sheet provide json api as well ?
  2. Maybe switch to https://github.com/Leonidas-from-XIV/node-xml2js which looks more maintained anyway. Looks like it has more or less same features set as the current xml parser, but I don't know how difficult it will be to switch.

— Reply to this email directly or view it on GitHub https://github.com/jpillora/node-edit-google-spreadsheet/issues/47#issuecomment-76143902 .

Exlipse7 commented 9 years ago

I tried installing this module and xml2json is failing in npm. This is due to dependence on node-expat which is listed as build-error on the npm site. Also, node-expat depends on node-iconv, which depends on node-gyp, which is miserable to install on windows machines as it requires specific versions of Python and Visual Studio to be installed. In reference to the above note on node-xml2js, I've used it before with no problem, but it's been several months so I'm not sure on it's current state.