search

jpillora / node-edit-google-spreadsheet

A simple API for editing Google Spreadsheets
304 stars 101 forks source link

Update metadata.js (this commit fixes #51) #50

Closed onlyurei closed 9 years ago

onlyurei commented 9 years ago

This commit fixes #51 (Can't read metadata):

  1. Fix url (remove '?alt=json') so we can get XML content instead of empty JSON content;
  2. Fix mismatched metadata JSON properties readings (updated, title, rowCount, colCount).
jpillora commented 9 years ago

Thanks Cheng, will take a look soon

On Thursday, December 4, 2014, Cheng Fan notifications@github.com wrote:

  1. Fix url (remove '?alt=json') so we can get XML content instead of empty JSON content;
  2. Fix mismatched metadata JSON properties readings (updated, title, rowCount, colCount).

You can merge this Pull Request by running

git pull https://github.com/onlyurei/node-edit-google-spreadsheet patch-1

Or view, comment on, or merge it at:

https://github.com/jpillora/node-edit-google-spreadsheet/pull/50 Commit Summary

  • Update metadata.js

File Changes

Patch Links:

- https://github.com/jpillora/node-edit-google-spreadsheet/pull/50.patch

— Reply to this email directly or view it on GitHub https://github.com/jpillora/node-edit-google-spreadsheet/pull/50.

jpillora commented 9 years ago

thanks for the PR and sorry for delay – even though the changes were the same, merged @ubik2's PR as he posted it back in Oct