search

jpillora / overseer

Monitorable, gracefully restarting, self-upgrading binaries in Go (golang)
MIT License
2.32k stars 207 forks source link

If fetcher is disabled, don't test to move files #17

Closed fmpwizard closed 7 years ago

fmpwizard commented 7 years ago

If the user only wants graceful restarts from this library, and the user running the go program doesn't have write access to the path to the binary, overseer fails to start with an error

[overseer] disabled. run failed: cannot move binary (exit status 1)

This commit checks if fetching is enabled, if not, it avoids the move check

jpillora commented 7 years ago

Ah true, will check this out tonight, thanks On Wed, 26 Jul 2017 at 9:49 pm Diego Medina notifications@github.com wrote:

If the user only wants graceful restarts from this library, and the user running the go program doesn't have write access to the path to the binary, overseer fails to start with an error

[overseer] disabled. run failed: cannot move binary (exit status 1)

This commit checks if fetching is enabled, if not, it avoids the move check

You can view, comment on, or merge this pull request online at:

https://github.com/jpillora/overseer/pull/17 Commit Summary

  • If fetcher is disabled, don't test to move files

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jpillora/overseer/pull/17, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmr81u0s4a6pGy61y9yR92xbkcdefjgks5sRyfBgaJpZM4Ojzzy .