search

jpillora / sshd-lite

A feature-light sshd(8) for Windows, Mac, and Linux written in Go
MIT License
88 stars 25 forks source link

Fix Windows build in Go 1.19 #4

Closed jpillora closed 8 months ago

jpillora commented 1 year ago

hey @Fusion, i needed to update deps to get latest Go ssh.

Moving up to Go 1.19 brakes only in windows. could you please check out: https://github.com/jpillora/sshd-lite/actions/runs/4232344720/jobs/7351964766

Will try to release with 1.17 for now... https://github.com/jpillora/sshd-lite/commit/06b36a6456e8582dcededd1980099e8c98262ddd

jpillora commented 1 year ago

No rush, I can comment out the windows builds for future releases

Fusion commented 1 year ago

OK I'l take a look. I was going to check it today but, no. Today is the day that I stupidly delete my dev VMs!

jpillora commented 1 year ago

Haha great timing

On Fri, 24 Feb 2023 at 2:03 pm Chris F Ravenscroft @.***> wrote:

OK I'l take a look. I was going to check it today but, no. Today is the day that I stupidly delete my dev VMs!

— Reply to this email directly, view it on GitHub https://github.com/jpillora/sshd-lite/issues/4#issuecomment-1442733170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2X4ZS7ZFGZLR63VUMFF3WZAQJ5ANCNFSM6AAAAAAVC6U4MM . You are receiving this because you authored the thread.Message ID: @.***>

Fusion commented 1 year ago

As you can see, I created a new pull request. As you can also see, it breaks sshd-lite's CI, which still relies on Go 1.17. I had to work around a breaking change in Go's internal API between both releases. Makes sense that 1.17 would not like what I did. Are you ok with only supporting Go 1.19+ or do you need backward compatibility? (I may be able to figure something out)

jpillora commented 1 year ago

hey @Fusion I'm happy to drop pre 1.19 support and go ahead with the windows fix (I am in sudden need to use a windows machine – unfortunately 😁)

jpillora commented 8 months ago

Closed in 6e023d9