search

jpillora / xdomain

A pure JavaScript CORS alternative
https://jpillora.com/xdomain/
3.13k stars 269 forks source link

Move xhook addCredentials into xdomain constructor #72

Closed matt-gadd closed 10 years ago

matt-gadd commented 10 years ago

Move the xhook addCredentials setting into xdomain constructor otherwise when using with an AMD loader xhook is undefined as not in global scope.

Not sure what your strategy is on the dist files in the repo - let me know if you don't want the updated files committed.

Thanks for the great work by the way :thumbsup:

jpillora commented 10 years ago

Hey Matt, thanks for the PR, changing the dist files is good :) though your fix won't always run since I've aliased addMasters and addSlaves. I think for this to work, it'll have to go in both branches of the this statement. I haven't used AMD in a long time so I think I'll leave the details to you :)

BaggersIO commented 10 years ago

@matt-gadd Thanks for the hint. I also moved the line temporarily to the constructor. AMD works fine now.

However I get: 

Uncaught ReferenceError: xhook is not defined

The error causes in initMaster

return xhook.before(function(request, callback) {
    var frame, p, socket;
    p = parseUrl(request.url);

Did you had the same issue?

Cheers!

jpillora commented 10 years ago

Fixed by grabbing the xhook from requirejs