jpjones76 / SeisIO.jl

Julia language support for geophysical time series data
http://seisio.readthedocs.org
Other
47 stars 21 forks source link

Bump HDF5.jl to 0.13+ #49

Closed shipengcheng1230 closed 3 years ago

shipengcheng1230 commented 4 years ago

Just out of curiosity, should we update the Compat for HDF5 using a higher version? For what I have known, there is one change since 0.13.0 that when indexing HDF5Dataset, the singleton dimension is automatically dropped, i.e d[:,:,1] where d <: HDF5Dataset, whereas previously not. Thanks for such great package!

jpjones76 commented 4 years ago

I'd prefer to keep the current HDF5 Compat entry because of https://github.com/JuliaIO/HDF5.jl/issues/609; but I can update that if you start seeing unsatisfiable requirements errors.

jpjones76 commented 3 years ago

https://github.com/JuliaIO/HDF5.jl/issues/609 has been fixed as of HDF5 0.13.5. I'll be updating SeisIO accordingly.