Closed tclements closed 3 years ago
Good point. Fixing this now.
In the future, we'll need to add an initialization method that creates a CuArray. I think that's as simple as importing SeisIO.NodalData to your GPU module and defining a new initialization function, but I haven't tested it...
Fixed on dev
Fixed on master and in the new release. Will close this issue as soon as Julia Registrator merges my PR(s).
Thinking about our move to the GPU, the
:data
field of theNodalData
struct will need to be of typeAbstractArray{Float32, 2}
to allow for transfer of data from CPU <-> GPU with Adapt.jl because:I think the
:x
field will work as is becauseFloatArray
isUnion{AbstractArray{Float32,1}, AbstractArray{Float64,1}}
and views work the same on the CPU and GPU though using:x
on the GPU will be quite inefficient: