search

jpjones76 / SeisIO.jl

Julia language support for geophysical time series data
http://seisio.readthedocs.org
Other
47 stars 21 forks source link

Bump compat for Blosc for "0.5.1, 0.6, 0.7" #58

Closed tclements closed 3 years ago

tclements commented 3 years ago

This is related to #49 - can we bump compatibility for Blosc.jl to "0.5.1, 0.6, 0.7"? I'm having trouble bundling SeisIO with the new AWS.jl in a package due to SeisIO fixed on Blosc v0.5.1

jpjones76 commented 3 years ago

Yep. Merged your PR into dev; will update master once the usual tests run. I did update HDF5 compatibility on master a couple of weeks ago (the HDF5.jl maintainers fixed the read slowdown issue)... but, weirdly, I didn't update dev. Very sorry!

tclements commented 3 years ago

Any chance you could merge the Blosc PR into master? Thanks!

jpjones76 commented 3 years ago

This...wasn't merged?

I have no idea how I missed that on master. Doing this immediately

jpjones76 commented 3 years ago

It's done. Sorry...I really thought I'd merged it to master (not just dev) after your PR finished tests.

tclements commented 3 years ago

Do you mind tagging a new release that includes these newer blosc versions? I'd like to incorporate these changes into another package that require blosc v0.6+. Thanks!

jpjones76 commented 3 years ago

I'm working on final tests for the next release. Should be ready Friday (01-29), if the documentation for SAC v102.0 is correct. (I can't really check in SAC itself. In the past, IRIS wouldn't let me download it without a .gov or .edu email address, which was pretty hilarious as a postdoc at ualberta.ca...)

tclements commented 3 years ago

Awesome, thanks!