Can't resolve path in tutorial/install.jl

jpjones76 / SeisIO.jl

Julia language support for geophysical time series data

http://seisio.readthedocs.org

Other

47 stars 21 forks source link

Closed adigitoleo closed 3 years ago

adigitoleo commented 3 years ago

Copying the line from the README:

cd(dirname(pathof(SeisIO))); include("../tutorial/install.jl")

results in an error (Linux) because the trailing slash is not added to pathof(SeisIO):

ERROR: LoadError: could not open file /home/leon/.julia/packages/SeisIO/xmXyu/tutorial../test/TestHelpers/0_check_deps.jl

The required diff for the tutorial/install.jl:

+ include(path * "/../test/TestHelpers/0_check_deps.jl")
- include(path * "../test/TestHelpers/0_check_deps.jl")

tclements commented 3 years ago

@adigitoleo I pushed a fix, we're hoping to get out a new version today.

jpjones76 commented 3 years ago

I'll merge @tclements PR into the main branch once current automated tests conclude.

jpjones76 commented 3 years ago

Merged and released with SeisIO v1.2.0. Please let me know that this is working, so I can close the issue.

adigitoleo commented 3 years ago

Yep it's working on v1.2 from github. Cheers.