jpl-x / x_multi_agent

Fork of x library for collaborative decentralized visual-inertial odometry
Apache License 2.0
86 stars 15 forks source link

High contrast photometric calibration images #4

Closed stephen9999999 closed 1 year ago

stephen9999999 commented 1 year ago

Hi, I turned the VERBOSE option to ON in the CMakeLists.txt, then the rviz can receive the trajectory topic and tracked feature topic. But, as shown in the following figure, the calibrated thermal images are much brighter than the result in the paper, how can I get the enhanced thermal images as shown in the paper? By the way, what's the black line in the calibrated images?

The calibrated image: 2022-11-09 15-02-42 的屏幕截图

The final estimated trajectory is not bad: 2022-11-09 15-06-17 的屏幕截图

viciopoli01 commented 1 year ago

hi @stephen9999999 ,

The black lines on the image represent the windows where a persistent landmark should be found. In other words, when you set the number of tiles in the parameters file, then the X library tries to distribute the landmarks more uniformly over the windows. Regarding the bright images, you can play with the params epsilon_gap and epsilon_base in the yaml file to have a darker image. Refer to the paper Online Photometric Calibration of Automatic Gain Thermal Infrared Cameras for more details.

Best, Vincenzo

stephen9999999 commented 1 year ago

Hi, Thanks for your suggestions. I have read the paper and tried to adjust the params but still cannot reproduce the results in the paper. With the PHOTOMETRIC_CALI ON, the contrast of images is lower than the raw images, and the noise is amplified. Therefore, the tracked feature number is less than the original images. Anything wrong? Looking forward to your suggestions. Thanks .

viciopoli01 commented 1 year ago

Hi,

This #5 should help. It can bring data race problems, but we tested with this piece of code that was missing in this release. Please let me know if it works for you.

Best, Vincenzo

viciopoli01 commented 1 year ago

Hi @stephen9999999, I will close this issue since there is not much activity here, and it should be solved. Please feel free to reopen it if you need to. Thanks. Best, Vincenzo