jplag / JPlag

State-of-the-Art Software Plagiarism & Collusion Detection
https://jplag.github.io/JPlag/
GNU General Public License v3.0
989 stars 290 forks source link

Update getName method in used in Language class #1767

Closed Mintype closed 1 month ago

Mintype commented 1 month ago

Hi! This pull request does everything that issue #1497 asks for, which is to clean up the getName() methods of many of the languages. Now they just will return the language name and not the parser name. Please tell me if I did anything wrong or if I have to change anything. Thanks a lot!

tsaglam commented 1 month ago

Just as general feedback, while granular committing is great, your commits are very atomic, meaning they encapsulate very few changes, which would make them generally considered a bit too fine-grained. This is not a problem for this PR though, as I can squash on merge.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Kr0nox commented 1 month ago

You will also need to update all names here https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts Depending on whether this will be a 5.1.0 or a 6.0.0 feature, we should keep the old names, to not break highlighting in these languages. @tsaglam Where do you think this PR will be included?

tsaglam commented 1 month ago

Where do you think this PR will be included?

I see this as a v6.0.0 feature, we can probably just merge this after the v5.1.0 release.

Mintype commented 1 month ago

You will also need to update all names here https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts

Depending on whether this will be a 5.1.0 or a 6.0.0 feature, we should keep the old names, to not break highlighting in these languages. @tsaglam Where do you think this PR will be included?

Ok I'll do this!

Mintype commented 1 month ago

wait a second. i forked the main branch not develop so I cant find https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts

Should I close this pull request and make a new one with the right branch?