Closed Mintype closed 1 month ago
Just as general feedback, while granular committing is great, your commits are very atomic, meaning they encapsulate very few changes, which would make them generally considered a bit too fine-grained. This is not a problem for this PR though, as I can squash on merge.
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
You will also need to update all names here https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts Depending on whether this will be a 5.1.0 or a 6.0.0 feature, we should keep the old names, to not break highlighting in these languages. @tsaglam Where do you think this PR will be included?
Where do you think this PR will be included?
I see this as a v6.0.0 feature, we can probably just merge this after the v5.1.0 release.
You will also need to update all names here https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts
Depending on whether this will be a 5.1.0 or a 6.0.0 feature, we should keep the old names, to not break highlighting in these languages. @tsaglam Where do you think this PR will be included?
Ok I'll do this!
wait a second. i forked the main branch not develop so I cant find https://github.com/jplag/JPlag/blob/develop/report-viewer/src/model/Language.ts
Should I close this pull request and make a new one with the right branch?
Hi! This pull request does everything that issue #1497 asks for, which is to clean up the getName() methods of many of the languages. Now they just will return the language name and not the parser name. Please tell me if I did anything wrong or if I have to change anything. Thanks a lot!